Shell's IDisposable implementation must dispose input stream if we own it
Open
@drieseng is already working on this.
Since Oct 26, 2023.
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 993
- Avg merge
- 9d 21h
- Merged PRs (30d)
- 1
Description
We have a few CreateShell(...) overloads on SshClient were we create the input stream that we pass to Shell.
When the Shell instance is disposed, we should dispose that input stream as well.
We should add CreateShell(...) overloads were we add a (bool) leaveOpen argument.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.