sromku / sromku/android-storage
Context is not necessary when only using ExternalStorage
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 900
- Forks
- 201
- PR merge metrics
- No merged PRs in 30d
Description
I used this library v1.2.1 in my App Pure Writer. It is great!
I turn to v2.1.0 today, and I found Context is not necessary when only using Storage.getExternalStorageDirectory(). It may be better and convenient that move the Context parameter to getInternalFilesDirectory() and getInternalCacheDirectory() which truly need the Context, and supply a Storage() constructor. How about it?
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Storage.getExternalStorageDirectory(), getInternalFilesDirectory(), and getInternalCacheDirectory(), then inspect how the current Storage constructor supplies Context. Confirm the proposed API change preserves external-storage use without Context while the two internal-directory methods still receive what they need; update the relevant tests or examples if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100