square / square/workflow-kotlin
Add Viewbinding as dependency, improve setup
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 1.1k
- Forks
- 112
- Avg merge
- 10h 5m
- Merged PRs (30d)
- 3
Description
Ontop of adding the android workflow lib, I had to add the androidx-viewbinding lib.
Maybe that libary can be added as dependency in the pom file, so it gets pulled in automatically?
implementation 'com.squareup.workflow1:workflow-ui-core-android:1.0.0-alpha.3'
implementation 'androidx.databinding:viewbinding:4.0.1'
It's also not really clear to me how to make the view binding actually work:
LayoutRunner.bind(HelloGoodbyeLayoutBinding::inflate) { rendering, _ ->
I'll try to look it up on the viewbinding readme, but ideally in my opinion this libary should work out of the box, without having to look into a 3rd party readme ;)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by checking the pom file and the Android workflow setup for where dependencies are declared, then trace the LayoutRunner.bind(HelloGoodbyeLayoutBinding::inflate) entry point. Done means ViewBinding is pulled in automatically and the setup explains how to make view binding work without relying on a third-party README.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- build-system, mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100