square / square/wire

Custom Java types

Open
#615 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Kotlin
Stars
4.4k
Forks
627
Avg merge
3d 15m
Merged PRs (30d)
20

Description

We’ve implemented some of custom proto adapters. Tracking outstanding work:

  • It should be possible to nest regular protos in custom adapter protos. Preferably using the same naming scheme we use when the enclosing class is pruned.
  • We should generate a new AbstractFooAdapter with methods like fromProto(String language, String country, String variant) and language(Locale locale)
  • We should support selecting fields as well as types. For dates!
  • We should support enums

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue tracks custom proto adapter generation, with unresolved requirements for nesting regular protos and selecting fields as well as types. Start by locating the custom adapter generation entry point and comparing the unchecked items with the completed adapter and enum work. Done means both remaining checklist items have an agreed implementation and verification.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kotlin
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.