square / square/wire

Projects not modular, duplicate packages across JARs

Open
#3,204 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
4.4k
Forks
627
Avg merge
3d 15m
Merged PRs (30d)
20

Description

There are projects that "export" the same packages (com.squareup.wire).

E.g.: wire.runtime.jvm and wire.schema.jvm

...which leads to errors like this, when building modular projects.

Error occurred during initialization of boot layer
java.lang.module.ResolutionException: Modules wire.runtime.jvm and wire.schema.jvm export package com.squareup.wire to module <something>

I don't know about the KT world, but this in a breach of JPMS guidelines.

Why can't we have modules-info.java or at least why do you have different JARs with the same packages?

Or am I missing something altogether in how to use these libs...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the wire.runtime.jvm and wire.schema.jvm JARs and reproducing the JPMS resolution error shown in the issue. Determine whether the artifacts can avoid exporting duplicate com.squareup.wire packages or whether supported modular usage must be documented; done means the modular-project failure has a clear resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kotlin
Domain
build-system
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.