square / square/wire

`GrpcClientTest.streamingRequestFailureWithUnexpectedHttpCode` is flaky

Open
#3,177 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug PR welcome!
Dominant language
Kotlin
Stars
4.4k
Forks
627
Avg merge
3d 15m
Merged PRs (30d)
20

Description

GrpcClientTest > streamingRequestFailureWithUnexpectedHttpCode FAILED
    org.junit.ComparisonFailure: 
    Expecting value to be true but was false expected:<[tru]e> but was:<[fals]e>
        at com.squareup.wire.GrpcClientTest$streamingRequestFailureWithUnexpectedHttpCode$2.invokeSuspend(GrpcClientTest.kt:1718)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:99)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at com.squareup.wire.GrpcClientTest.streamingRequestFailureWithUnexpectedHttpCode(GrpcClientTest.kt:1709)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with GrpcClientTest.kt around lines 1709-1718 and run streamingRequestFailureWithUnexpectedHttpCode repeatedly to reproduce the flake. Trace the intermittent false assertion and make the test reliable, then confirm the test passes consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.