square / square/wire

Fix MissingRequiredFields usage

Open
#2,553 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
4.4k
Forks
627
Avg merge
3d 15m
Merged PRs (30d)
20

Description

Right now, we pass the null field as well, which is useless and create noise.

For instance: id = id ?: throw missingRequiredFields(id, "id"),.

Confirm what's up in Java.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the MissingRequiredFields usage shown in the issue and compare the Kotlin call with its Java usage. Confirm whether the null field can be omitted without changing the required-field error, and verify that the resulting usage no longer passes the null value or creates extra noise.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kotlin
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.