square / square/wire

wire-swift proto3 working document

Open
#1,925 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
4.4k
Forks
627
Avg merge
3d 15m
Merged PRs (30d)
20

Description

Similar to #279, we'd like to track work that enables proto 3 support in wire-swift. This issue will start small and be updated as more is discovered.

  • Support for Google.Protobuf.WellKnownTypes
    • Duration code generation from duration.proto
      • Duration <-> TimeInterval lossy interop
      • Remove redundant Wire import statement
      • Generate swift test file from golden proto that contains Duration
    • TimeStamp code generation from timestamp.proto
    • Scalar wrapper types
      • BoolValue
      • BytesValue
      • DoubleValue
      • FloatValue
      • Int32Value
      • Int64Value
      • ListValue
      • StringValue
      • UInt32Value
      • UInt64Value

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the completed Duration work, including wire-runtime-swift/src/main/swift/wellknowntypes/Duration.swift, duration.proto, and the golden proto test mentioned in the checklist. Compare that path with the unchecked timestamp.proto and scalar wrapper entries, then use the existing Swift generation tests to define what completion requires.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.