square / square/square-php-sdk
GuzzleHttp ClientInterface detection in RetryDecoratingClient
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 77
- Forks
- 54
- Avg merge
- 2h 14m
- Merged PRs (30d)
- 1
Description
📝 Overview
RetryDecoratingClient used class_exists('GuzzleHttp\ClientInterface') to detect whether the configured HTTP client implements Guzzle's ClientInterface. Since ClientInterface is a PHP interface rather than a class, class_exists() never matches it, so the Guzzle-specific send path was never taken.
#188
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating RetryDecoratingClient and inspect its HTTP-client detection logic and nearby tests. Verify the behavior with a Guzzle client and confirm that the Guzzle-specific send path is selected; run the relevant test suite to ensure other client handling remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 75/100