Runner script dropping the existing triggers
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 737
- Forks
- 52
- Avg merge
- 4d 4h
- Merged PRs (30d)
- 1
Description
The runner script has dropped the old triggers for the table.
Logs:
I0118 13:00:53.844432 06964 runner.go:775] mig_id=9: cleaning up.
I0118 13:00:53.845156 06964 migration.go:322] mig_id=9: cleaning up triggers.
I0118 13:00:53.845193 06964 migration.go:350] mig_id=9: Running query 'SELECT trigger_name FROM information_schema.triggers WHERE trigger_schema=? AND event_object_table=?' (args: [stage t1]).
I0118 13:00:53.849166 06964 migration.go:357] mig_id=9: Query response was 'map[trigger_name:[check_trigger]]'
I0118 13:00:53.849207 06964 migration.go:364] mig_id=9: Running query 'DROP TRIGGER IF EXISTS `stage`.`check_trigger`'.
I0118 13:00:53.850382 06964 migration.go:328] mig_id=9: cleaning up shadow table.
is that expected behavior ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading runner.go around lines 703 and 775, then migration.go around lines 322-364, where cleanup queries and drops triggers. Reproduce the migration against a MySQL table with an existing trigger and determine whether cleanup should preserve it. Done means the trigger behavior is corrected or explicitly confirmed with a regression test or documented result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, ruby
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100