square / square/Listable

Fix underscroll footers when a keyboard is visible

Open
#84 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
210
Forks
35
Avg merge
1h 34m
Merged PRs (30d)
1

Description

This PR https://github.com/kyleve/Listable/pull/83/files ended up breaking properly showing the underscroll footer when the keyboard is up, due to the contentInset addition. This was added to properly show the underscroll footer in horizontal scrolling lists, so need to figure out a solution that works for both.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing PR 83's diff, especially the contentInset addition described in this issue, and trace how it affects underscroll footers with the keyboard visible and in horizontal lists. Done means both keyboard-visible footers and horizontal-scrolling footers display correctly without regressing either behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.