square / square/Blueprint

unnecessary call of setNeedsViewHierarchyUpdate() in didMoveToWindow

Open
#185 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
707
Forks
49
PR merge metrics
No merged PRs in 30d

Description

It causes unnecessary rendering of the element even if we push another view controller.
This leads to the app freeze if there are lots elements in element....

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the didMoveToWindow implementation and its call to setNeedsViewHierarchyUpdate(). Reproduce navigation to another view controller with many elements and verify whether the call causes unnecessary rendering or an app freeze. Done means the unnecessary update is avoided without breaking view hierarchy updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.