sqlitebrowser / sqlitebrowser/sqlitebrowser

Can close in-memory database without 'are you sure?' prompt

Open
#2,864 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
24.6k
Forks
2.4k
Avg merge
3d 49m
Merged PRs (30d)
3

Description

This is weird.
If you create an in-memory database and close DB4S, it throws up a 'are you sure?' message. However, if there are no changes to make, it doesn't.

https://user-images.githubusercontent.com/7872218/136902869-1f4a562f-65a9-4ac8-9ecf-11e5a732cd45.mp4

Tried on the 12 Sep nightly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by creating an in-memory database in DB4S, closing it with no changes, and comparing the prompt behavior. Trace the close handling and unsaved-change detection; done means an unchanged in-memory database closes without the confirmation prompt while databases with changes retain the warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, sqlite
Domain
databases, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.