sqldelight / sqldelight/sql-psi

Fail ordered sql files if they end with a transaction open

Open
#223 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core
Dominant language
Kotlin
Stars
104
Forks
35
Avg merge
1h 11m
Merged PRs (30d)
14

Description

Dialect: ALL

failing sql:

BEGIN TRANSACTION;

-- do stuff

should fail to compile because the transaction wasn't closed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the ordered SQL example with an unclosed BEGIN TRANSACTION and trace the ordered-file compilation path. Verify behavior across all dialects; done means an ordered SQL file ending with an open transaction fails to compile.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin, sql
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.