sqlalchemy / sqlalchemy/mako

"\" at end of comment lines

Open
#307 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
459
Forks
90
PR merge metrics
No merged PRs in 30d

Description

Mako 1.1.0 is wrongly interpreting backslash ("\") as a newline filter in comments ("##").

Expected behavior: "\" is ignored in comments
Observed behavior: following line is treated as comment

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies Mako comment lines using ## and the backslash behavior, but names no source file or test. Start by reproducing the reported Mako 1.1.0 behavior with a comment containing a trailing backslash, then locate the comment parsing tests and confirm that the following line is no longer treated as a comment.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.