sqlalchemy / sqlalchemy/dogpile.cache

cache_on_arguments' expiration_time doesn't accept timedelta

Open
#50 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature low priority
Dominant language
Python
Stars
299
Forks
50
PR merge metrics
No merged PRs in 30d

Description

Migrated issue, originally created by Antoine Bertin (diaoul)

This is feature is already working for the expiration_time in region.configure.
I think this should be extended to all expiration_time arguments to make this argument consistent across dogpile.cache.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating cache_on_arguments and the existing expiration_time handling in region.configure. Compare the related tests and determine which expiration_time arguments are covered. Done means timedelta values are accepted consistently across dogpile.cache expiration_time arguments, with tests covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.