sqlalchemy / sqlalchemy/dogpile.cache
use TypedDict for backend arguments dictionaries
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 299
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
I'm in the process of updating some legacy stuff that has been pinned to < 1.10 , when the serialization was decoupled
Re:
https://github.com/sqlalchemy/dogpile.cache/pull/191
https://github.com/sqlalchemy/dogpile.cache/commit/21c38da5034d1fafb0b73313540b71d7f785e207
The big issue that lost most of my day: The changelog does not accurately reflect that Redis (and other "Bytes" backends) [should] now use set_serialized instead of set.
While updating, a possible improvement jumped at me - is there any interest in making the config dicts TypedDicts ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the changelog and the Redis and other Bytes backends, including their use of set_serialized rather than set. Start by tracing the backend argument dictionaries in those areas; done means the intended configuration dictionaries are represented with TypedDicts without changing the backend behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, redis
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100