sqlalchemy / sqlalchemy/dogpile.cache
refresh() method does not honors should_cache_fn function
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 299
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
Migrated issue, originally created by Anonymous
CacheRegion.cache_on_arguments() has a parameter should_cache_fn which is used to control if content should be cached or not. the .refresh() method on the decorated function ignores it and goes directly to the backend.set()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with CacheRegion.cache_on_arguments() and the decorated function's refresh() method, then trace how should_cache_fn is handled during normal caching. Update the refresh path so its behavior matches that contract, and verify that the backend is only updated when should_cache_fn permits caching.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100