sqlalchemy / sqlalchemy/alembic
do not rely on reflection applying naming conventions
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 375
- PR merge metrics
- No merged PRs in 30d
Description
Migrated issue, originally created by Michael Bayer (@zzzeek)
the naming convention feature added in 735889f068c58f8a278dcfe5bda7496624339026 will require adjustment per SQLAlchemy issue https://bitbucket.org/zzzeek/sqlalchemy/issues/3818/naming-convention-should-not-fire-off-on. Reflection should not be applying naming constraints and Alembic's feature here will need to use some new flag, e.g. apply_naming_conventions. Base this on detection of version 1.2 or whatever we put it in.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the naming-convention feature introduced in commit 735889f068c58f8a278dcfe5bda7496624339026 and the linked SQLAlchemy issue 3818. Determine how reflection currently applies naming constraints and how version 1.2 or an explicit apply_naming_conventions flag should control that behavior; done means reflection no longer applies conventions unintentionally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100