sqlalchemy / sqlalchemy/alembic

produce "raise on execute" symbols that we can put in places we know that "None" will fail, like UniqueConstraint(None), etc.

Open
#169 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

autogenerate - rendering bug Tier 2
Dominant language
Python
Stars
4.4k
Forks
375
PR merge metrics
No merged PRs in 30d

Description

Migrated issue, originally created by Ulrich Petri (@ulope)

When adding unique=True to an existing column the generated migration looks like this:

def upgrade():
    op.create_unique_constraint(None, 'table', ['field'])


def downgrade():
    op.drop_constraint(None, 'table')

I think alembic should either autogenerate a constraint name (I realize this might be difficult across backends) or print a very explicit warning that the migration needs to be 'fixed' manually.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how autogeneration turns an existing column with unique=True into upgrade() and downgrade() calls using None for constraint names. The issue names no files or tests, so first locate the relevant migration-generation and constraint-handling entry points, then clarify whether completion means generating names or emitting an explicit warning, with coverage for both generated functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlalchemy
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.