sqlalchemy / sqlalchemy/alembic

Improve server_default / existing_server_default typing

Open
#1,468 2 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug pep 484
Dominant language
Python
Stars
4.4k
Forks
375
PR merge metrics
No merged PRs in 30d

Description

The public typing have an incorrect type for it.
Use the correct one defined here:

https://github.com/sqlalchemy/alembic/blob/ade17cfd8dd1a12d6babceb24126511ddab1085a/alembic/ddl/base.py#L39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the public typing for server_default and existing_server_default, then compare it with the definition in alembic/ddl/base.py at line 39 from the linked source. Update the public annotations to use the referenced type and verify that both names match the definition.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlalchemy
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.