sqlalchemy / sqlalchemy/alembic
Change the default `include_schemas` to be `"from_metadata"`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 375
- PR merge metrics
- No merged PRs in 30d
Description
I mean something the following:
False-> use only the default schemaTrue-> check all schemas'from_metadata'-> new default, behave asFalseif themetadata.schemaisNoneor asTruewith a name filter to the schema specified in the metadata if themetadata.schemais defined?
I think this new default would do the correct thing in most cases, meaning that an user has to change the include_schemas only if having tables on multiple schemas at the same time
Originally posted by @CaselIT in https://github.com/sqlalchemy/alembic/discussions/1425#discussioncomment-8499832
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name implementation files or tests. Start by locating Alembic's handling and tests for the include_schemas option, then compare the existing False and True behavior with the proposed from_metadata cases; done means the default follows metadata.schema while explicit values retain their documented behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100