sqlalchemy / sqlalchemy/alembic
Autogenerate migration still has minor typing issues with mypy
Open
Beginner friendly
Nobody has claimed this yet.
bug
open for pull requests
pep 484
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 375
- PR merge metrics
- No merged PRs in 30d
Description
The fix for #1253 looks slightly incorrect as the type for down_revision should be Union[str, Sequence[str], None] and not Union[str, None]. down_revision is a tuple for merge revisions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the fix for issue #1253 and the autogenerate migration code where down_revision is typed. Check the annotation with mypy, including merge revisions where down_revision is a tuple. Done means the type accepts str, Sequence[str], and None without typing errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sqlalchemy
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 74/100