sqlalchemy / sqlalchemy/alembic

private constructor elements on CreateTableOp make it impossible to copy w/ public API

Open
#1,193 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug op directives
Dominant language
Python
Stars
4.4k
Forks
375
PR merge metrics
No merged PRs in 30d

Description

Discussed in https://github.com/sqlalchemy/alembic/discussions/1192

private attributes in 3b09a89d and 6aad6860 seem to be breaking the recipe at https://alembic.sqlalchemy.org/en/latest/cookbook.html#apply-custom-sorting-to-table-columns-within-create-table ; at least _namespace_metadata seems to be required as illustrated at #1192.

see if these private attributes can somehow be set up so that the recipe works again without these being named

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the custom column-sorting recipe in the Alembic cookbook and the discussion at sqlalchemy/alembic#1192. Inspect CreateTableOp and the changes in commits 3b09a89d and 6aad6860, especially _namespace_metadata. Done means the recipe can copy or configure the operation through the public API without naming private attributes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.