Release file sql-wasm.js doesn't support JSON1 after rebuilding, but debug one does.
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 13.7k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I clone the project and did the modification in makefile to support JSON1.
CFLAGS = \
-O2 \
-DSQLITE_OMIT_LOAD_EXTENSION \
-DSQLITE_DISABLE_LFS \
-DSQLITE_ENABLE_FTS3 \
-DSQLITE_ENABLE_FTS3_PARENTHESIS \
-DSQLITE_ENABLE_FTS5 \
-DSQLITE_ENABLE_JSON1 \
-DSQLITE_THREADSAFE=0 \
-DSQLITE_ENABLE_NORMALIZE
Then rebuild
npm run rebuild
The output files in dist folder, I found that only debug one (sql-wasm-debug.js) supports JSON1 by running some test code. But the release file sql-wasm.js doesn't support JSON1.
Is there any idea how to resolve this issue? Thank you
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Makefile CFLAGS and the npm run rebuild entry point, then compare how sql-wasm.js and sql-wasm-debug.js are produced in dist. Reproduce the JSON1 test against both outputs and trace the release build configuration; done means the rebuilt release file supports JSON1 as the debug file does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, sqlite, wasm
- Domain
- build-system, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100