spyoungtech / spyoungtech/FreeSimpleGUI
`drop_whitespace` argument only present for basic popup
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 867
- Forks
- 106
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
Hi,
I'm trying to use a yes/no popup with some whitespace surrounding the text (in order to make the popup title fully visible in all cases, regardless of popup text length). But the popup trims the whitespace.
The drop_whitespace parameter is only available for the basic popup, not for the other text-based popups (e.g. popup_yes_no).
A simple workaround is to use popup(button_type=POPUP_BUTTONS_OK_CANCEL, drop_whitespace=False), I wonder how you feel about adding the drop_whitespace parameter to the other relevant functions?
I can do the work and raise a PR if it's a good idea.
I think the relevant functions are any that just make a call to popup:
popup_non_blocking, popup_quick, popup_quick_message, popup_no_titlebar, popup_auto_close, popup_error, popup_cancel, popup_ok, popup_ok_cancel and popup_yes_no.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the listed popup helper functions, including popup_yes_no and popup_ok, and inspect how each calls the basic popup. Add the optional argument consistently to the relevant helpers, then verify that passing drop_whitespace=False preserves surrounding whitespace in each text-based popup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100