spullara / spullara/mustache.java

Support Java Modules

Open
#289 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
2k
Forks
281
PR merge metrics
No merged PRs in 30d

Description

v0.9.10 defines an automatic module name

$ jarviz module descriptor --file compiler-0.9.10.jar 
name: com.github.mustachejava
version: 0.9.10
open: false
automatic: true
requires:
  java.base mandated
contains:
  com.github.mustachejava
  com.github.mustachejava.codes
  com.github.mustachejava.functions
  com.github.mustachejava.reflect
  com.github.mustachejava.reflect.guards
  com.github.mustachejava.resolver
  com.github.mustachejava.util

I'd be great if the library supplied a full Java module descriptor. It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect. This will help modular projects that consume mustache-java, specifically those that create custom Java Runtimes with jlink, as the latter does not support automatic modules but explicit modules. If interested I can send a PR to make it happen.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the build configuration and the generated compiler-0.9.10.jar module metadata; the issue names ModiTect as the approach to investigate. Done means the library supplies a full, explicit Java module descriptor while remaining bytecode-compatible with Java 8 and usable by jlink.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.