spring-projects / spring-projects/spring-ws
XmlRootElementPayloadMethodProcessor supports requests annotated with XmlType, but not responses annotated with XmlType [SWS-953]
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 346
- Forks
- 323
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 7
Description
Alex Hutnik opened SWS-953 and commented
In XmlRootElementPayloadMethodProcessor, supportsRequestPayloadParameter() supports both XmlRootElement-annotated classes and XmlType-annotated classes. However, supportsResponsePayloadReturnType supports only XmlRootElement-annotated classes.
My XSD's types are all named (that is, no anonymous types in my XSD), so their generated-class equivalents are annotated with XmlType, not XmlRootElement. This bug is preventing me from using my return types.
Affects: 2.2.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with XmlRootElementPayloadMethodProcessor, comparing supportsResponsePayloadReturnType() with supportsRequestPayloadParameter(). Confirm how XmlType-annotated generated classes are detected, then add coverage for a response return type using XmlType. Done means supported XmlType responses are handled without regressing XmlRootElement responses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100