spring-projects / spring-projects/spring-vault

Make properties vault.addr and vault.uri equivalent

Open
#592 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: ideal-for-contribution type: enhancement
Dominant language
Java
Stars
306
Forks
202
PR merge metrics
No merged PRs in 30d

Description

Vault defines an environment variable VAULT_ADDR to hold the Vault URL for the vault command line reference client. Spring Vault defines an equivalent property vault.uri in its EnvironmentVaultConfiguration class.

Is it reasonable to enhance EnvironmentVaultConfiguration so that it treats vault.uri and a proposed vault.addr as equivalent, given VAULT_ADDR is an existing well-known name in Vault operation?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the EnvironmentVaultConfiguration class and the linked Vault VAULT_ADDR and Spring Vault vault.uri documentation. Trace how the existing vault.uri property is resolved, then determine the expected precedence and behavior when vault.addr is present. Done means both properties are treated equivalently without changing existing vault.uri behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.