spring-projects / spring-projects/spring-tools

[spring index] optimize super type information for beans with hash codes instead of strings

Open
#1,045 0 comments 0 reactions 1 assignee View on GitHub

@martinlippert is already working on this.

Since May 10, 2023.

for: eclipse for: vscode theme: spring index & symbols type: enhancement
Dominant language
Java
Stars
983
Forks
240
Avg merge
7d 1h
Merged PRs (30d)
7

Description

The only purpose of keeping all the super types of a bean type within the spring index is to check for type compatibility. This could be optimized in a way to not store the fully qualified type information as strings in the index storage, but hash codes only (and then compare hash codes instead of type strings).

While this seems to be straight forward and easy to do, we need to verify that this covers all the ways a bean is being found when looking for a compatible bean. Generics might be a potential complicated case here, but we need to double check while implementing this optimization here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.