spring-projects / spring-projects/spring-session
uri fragments handled incorrectly by CookieHttpSessionStrategy.encodeUrl
Open
Nobody has claimed this yet.
status: waiting-for-triage
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 55
Description
URI Fragments are not handled properly by encodeUrl. See test below.
Using UriComponentsBuilder in encodeUrl fixes this issue.
@Test
public void encodeUrlWithFragment() {
assertThat(new CookieHttpSessionStrategy().encodeURL("/url?a=b#xyz", "2"))
.isEqualTo("/url?a=b&_s=2#xyz");
}}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CookieHttpSessionStrategy.encodeURL and reproduce the issue with the provided encodeUrlWithFragment test. Compare the URI handling with UriComponentsBuilder; done means the session parameter is inserted before the fragment and the test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100