spring-projects / spring-projects/spring-session
Duplicate PRINCIPAL_NAME_INDEX_NAME
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 55
Description
We are developing our own repository extension for storing spring session. In the spring codebase there are two PRINCIPAL_NAME_INDEX_NAME constants, one being the FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME and the other is ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME. In all the spring session repository implementations FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME is used to extract the principal. What is the use of ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the declarations of FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME and ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME, then search the repository implementations for each usage. Compare their intended roles and determine whether the duplicate reactive constant is needed; done should be a documented resolution or a clearly scoped follow-up change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100