spring-projects / spring-projects/spring-session
Programmatically Disable CSRF for x-auth-token
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 55
Description
We should provide a way for Spring Session to programmatically disable Spring Security's CSRF support on requests in which x-auth-token is used for establishing the session.
We could perhaps disable CSRF in Spring Security when:
- x-auth-token is provided
- No cookies are present (specifically JSESSIONID, but remember the cookie name can be configured)
We should be mindful of how this works in a CORS scenario.
If changes are made to Spring Security we should be mindful of how this will work in an OAuth Scenario
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Trace Spring Session's x-auth-token session-establishment path and Spring Security's CSRF handling, then examine the stated no-cookie and configurable JSESSIONID conditions in CORS and OAuth scenarios; done means the behavior is programmatically supported and those scenarios are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100