spring-projects / spring-projects/spring-session
Consider making Session implementations public
Open
@marcusdacoregio is already working on this.
Since Mar 15, 2023.
for: team-attention
in: jdbc
in: mongo-db
in: redis
type: enhancement
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 55
Description
Expected Behavior
It should be possible to extend or delegate to those implementations.
Current Behavior
SessionRepositoryimplementations are open for extension but cannot be extended, e.g. there is no way to overridecreateSessionorsavemethods.- This issue mentions that the
MongoSessionis an internal implementation detail of theMongoIndexedSessionRepositoryimplementation. That actually is not 100% true sinceMongoSessionis returned by the API. - The
AbstractMongoSessionConverteris meant to be extended accordingly to its javadoc, but it is not possible since its abstract methods work withMongoSessionand that implementation is package-private - Since each implementation is part of the public API, it is strange that they are not public
Context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.