spring-projects / spring-projects/spring-session

hazelcast4 is not included in sources.jar, but in the lib jar

Open
#1,858 4 comments 1 reaction 1 assignee View on GitHub

@eleftherias is already working on this.

Since May 31, 2021.

in: hazelcast type: bug
Dominant language
Java
Stars
1.9k
Forks
1.2k
Avg merge
4h 27m
Merged PRs (30d)
55

Description

Describe the bug

both 2.4.3 & 2.5.0, the lib jar contains hazelcast4*, but the sources.jar does Not.

the lib jar contains the class from both (1) & (2),but the sources.jar missing (1)

  • (1)spring-session/spring-session-hazelcast/hazelcast4/hazelcast4.gradle
  • (2)spring-session/spring-session-hazelcast/spring-session-hazelcast.gradle

To Reproduce

diff the lib jar and source jar.

  1. download them by maven or http
  2. unzip them
  3. diff them

Expected behavior

keep the lib jar and sources.jar same.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.