spring-projects / spring-projects/spring-session

Improve JDBC repository session clean-up job

Open
#1,739 0 comments 4 reactions 1 assignee View on GitHub

@vpavic is already working on this.

Since Nov 30, 2020.

in: jdbc status: waiting-for-triage type: enhancement
Dominant language
Java
Stars
1.9k
Forks
1.2k
Avg merge
4h 27m
Merged PRs (30d)
55

Description

See #838 for background (and more specifically this comment).

The approach with a single SQL statement based session clean-up job has been historically been somewhat problematic, seeing several revisions to address issues seen with specific RDMBSs. The currently used statement is susceptible to deadlocks in MySQL/MariaDB and SQL Server.

We should consider improving the session clean-up job so that it:

  • is more robust, i.e. isn't susceptible to deadlocks
  • provides more insight into expired sessions (debug logs etc.)
  • doesn't execute on multiple nodes simultaneously in a cluster out-of-the-box
  • is easier to customize

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.