spring-projects / spring-projects/spring-session

Support for multiple domains when writing the session cookie

Open
#1,453 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
1.9k
Forks
1.2k
Avg merge
4h 27m
Merged PRs (30d)
55

Description

Hi Spring Team,

I came up to a situation where I need to issue the session cookie for 2 different domains.
Didn't find that in docs neither in code, since org.springframework.boot.web.servlet.server.Session has only 1 Cookie and org.springframework.session.web.http.DefaultCookieSerializer.writeCookieValue() seems to be called only once and also writes to response once.

Is there a way to do it (maybe I'm missing smth)? Or do you plan to have it soon?

For reference, I found these issues that seem to be diff but related #1323 #297 #299 #162 #955

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading org.springframework.boot.web.servlet.server.Session and org.springframework.session.web.http.DefaultCookieSerializer.writeCookieValue(), the two entry points named in the issue. Check the related issues #1323, #297, #299, #162, and #955 for existing decisions; the work is not ready until the supported behavior for issuing a session cookie across two domains is agreed and testable.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.