spring-projects / spring-projects/spring-session
Reconsider handling of SessionRepository#save for invalidated sessions
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.2k
- Avg merge
- 4h 27m
- Merged PRs (30d)
- 55
Description
At present, the SessionRepository implementations are silent when an invalid session is passed to #save operation. This can have unexpected consequences in further processing of HTTP request, since it operates under assumption that the saved session is still valid - i.e. there's no difference in #save when passed in session is valid vs invalid.
One option could be (depending on the nature of the underlying data store) to do a read before saving a session, and throw an error if session is missing/invalid.
We could look at WebSession#save for inspiration - see #1135.
/cc @rwinch @jxblum @gregturn
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the SessionRepository implementations and WebSession#save, using issue #1135 for context. Determine the intended behavior when #save receives an invalid session and how it depends on the underlying data store; the work is done when that behavior and its error handling are agreed and consistently covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100