spring-projects / spring-projects/spring-security

Add Kotlin DSL support for configuring AuthenticationDetailsSource of FormLogin and RememberMe

Open
#9,788 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: config status: feedback-provided type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Currently, the AuthenticationDetailsSource can only be configured for httpBasic and x509. In theory, the same support for formLogin, rememberMe, and oauth2Login could also be added. It would be great if we can have the full coverage for this configuration.

Aside from missing configurations in Kotlin DSL, I personally found it is seemingly impossible to extend the existing Kotlin DSL to add our own in cases like this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing Kotlin DSL support for AuthenticationDetailsSource in httpBasic and x509 with the formLogin and rememberMe configuration entry points. Determine the configuration coverage needed for both features and verify it with the relevant Spring Security tests; done means AuthenticationDetailsSource can be configured through the Kotlin DSL for form login and remember-me authentication.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, kotlin
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.