spring-projects / spring-projects/spring-security

Support unsigned ID tokens for OIDC

Open
#9,494 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: oauth2 type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Describe the bug
Our attempt to certify our OIDC support with OpenID failed because Spring Security OIDC doesn't support unsigned ID tokens. As OIDC standard requires clients to support unsigned ID tokens I think Spring implementation shall allow them. It can be disallowed by default but it shall be possible to configure filter to support it.

BTW underlying Nimbus library allows unsigned ID tokens.

To Reproduce
Just point you sample or any other web application with OIDC filter to OpenID certification site and run the oidcc-client-test-idtoken-sig-none test.

BTW I think it is a good idea to certify every your release.

Expected behavior
It shall support unsigned ID tokens.

Sample

A link to a GitHub repository with a minimal, reproducible sample.

Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the OIDC filter configuration and its Nimbus-backed ID-token validation path, then run the OpenID certification test oidcc-client-test-idtoken-sig-none. Done means unsigned ID tokens are accepted when explicitly configured while the default behavior remains disallowed.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.