spring-projects / spring-projects/spring-security
ACL add String AccessControlEntry#getKey()
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
In our project we have very complex security restrictions.
When some Start event happens we grant some permissions to a set of sids.
But when the corresponding End event happens we should revoke exactly the same set of permissions.
It would be great if we can pass some optional key attribute to MutableAcl::insertAce method.
In this case when the corresponding End event happens we can just remove all aces by passed key.
This change can be made fully backward compatible.
Will you accept PR from me with this change?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the MutableAcl::insertAce entry point and the AccessControlEntry#getKey() API mentioned in the issue. Trace how ACEs are added and removed, then define the backward-compatible behavior for optional keys and removal by key. Done means the ACL API supports the requested key-based lifecycle without breaking existing callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authorization, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100