spring-projects / spring-projects/spring-security
Add HSM Support for Signing AuthnRequests
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
It would be nice to allow for a custom signer in OpenSamlAuthenticationRequestFactory. This would simplify delegating the signing to a separate service.
It's not yet clear how best to expose this functionality since signing patterns are different for HTTP-Redirect and HTTP-POST bindings.
For the redirect binding, one signs a query string composed of the serialized <saml2:AuthnRequest>, the signature algorithm, and any relay state.
For the post binding, one signs the XML payload and embeds the signature into the payload.
As use cases come in, it should become clearer what the contract should look like.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with OpenSamlAuthenticationRequestFactory and compare the signing requirements for HTTP-Redirect and HTTP-POST bindings described in the issue. Define a custom-signer contract that can support both serialized query-string signing and XML-payload signing, then verify that the resulting behavior matches each binding's requirements.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100