spring-projects / spring-projects/spring-security

A way to re-enable CSRF for OAuth2 bearer token requests

Open
#8,668 11 comments 6 reactions 1 assignee View on GitHub

@jzheaux is already working on this.

Since Jun 9, 2020.

in: oauth2 type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

We have user-facing services which are accessed via OAuth2 proxy, so they are configured as resource server and bearer token is added to request headers by the proxy (from client session).

Currently OAuth2ResourceServerConfigurer.registerDefaultCsrfOverride is called unconditionally and it makes it impossible to use conventional CSRF configuration.

On reactive side there seems to be a solution (not tested though): when custom requireCsrfProtectionMatcher is specified, the override is not applied. Similar behaviour could be implemented for servlet security by introducing specifiedRequireCsrfProtectionMatcher flag on CsrfConfigurer.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.