spring-projects / spring-projects/spring-security
Use @NonNullApi for null-safety
Open
@jzheaux is already working on this.
Since Dec 22, 2022.
in: core
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
Use @NonNullApi annotation as Spring Core did.
Actual Behavior
Many parts of the API like ClaimAccessor return null, so it's easy to cause NPE if you don't read JavaDoc carefully.
Expected Behavior
Use @NonNullApi and @Nullable at least for part of the API.
Configuration
Version
All versions up to today's master.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.