spring-projects / spring-projects/spring-security

SAML: Document how to change validation for audiences when using example IssuerSaml2AuthenticationRequestFactory

Open
#8,320 0 comments 0 reactions 1 assignee View on GitHub

@jzheaux is already working on this.

Since Apr 3, 2020.

in: docs type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Summary

The documentation shows as example IssuerSaml2AuthenticationRequestFactory on how to get "more control", but it does not show, how to update the validation for SAML2AssertionValidationParameters.COND_VALID_AUDIENCES when the IdP uses the "calculated" issuer as audience.

https://github.com/spring-projects/spring-security/blob/master/docs/manual/src/docs/asciidoc/_includes/servlet/saml2/saml2-login.adoc

Expected Behavior

Updated documentation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.