spring-projects / spring-projects/spring-security
An invalid remember-me cookie should throw a RememberMeAuthenticationException
Open
Nobody has claimed this yet.
status: waiting-for-triage
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
If an invalid remember-me token is provided by a counterfeit cookie, an IllegalArgumentException is thrown:
java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 1 in: "3J"
at java.base/java.net.URLDecoder.decode(URLDecoder.java:232) ~[na:na]
at java.base/java.net.URLDecoder.decode(URLDecoder.java:142) ~[na:na]
at org.springframework.security.web.authentication.rememberme.AbstractRememberMeServices.decodeCookie(AbstractRememberMeServices.java:242) ~[spring-security-web-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.security.web.authentication.rememberme.AbstractRememberMeServices.autoLogin(AbstractRememberMeServices.java:135) ~[spring-security-web-5.1.5.RELEASE.jar:5.1.5.RELEASE]
at org.springframework.security.web.authentication.rememberme.RememberMeAuthenticationFilter.doFilter(RememberMeAuthenticationFilter.java:98) ~[spring-security-web-5.1.5.RELEASE.jar:5.1.5.RELEASE]
Expected Behavior
A RememberMeAuthenticationException is thrown.
Version
spring-security-web-5.1.5.RELEASE.jar:5.1.5.RELEASE
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in org.springframework.security.web.authentication.rememberme.AbstractRememberMeServices, particularly decodeCookie and its caller autoLogin, following the stack trace from the invalid cookie. Reproduce the malformed token and verify that the observed IllegalArgumentException is replaced by the expected RememberMeAuthenticationException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100