spring-projects / spring-projects/spring-security
WebSecurityConfiguration NullPointerException when ObjectPostProcessor is not present
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration.objectObjectPostProcessor field is marked as not required. When it is not present, the method springSecurityFilterChain throws a NullPointerException
Actual Behavior
If there are webSecurityConfigurers, and there is no objectObjectPostProcessor org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration.springSecurityFilterChain() throws NPE in line number 99. (Version 5.1.5-RELEASE).
The method looks like this currently:
/**
* Creates the Spring Security Filter Chain
* @return the {@link Filter} that represents the security filter chain
* @throws Exception
*/
@Bean(name = AbstractSecurityWebApplicationInitializer.DEFAULT_FILTER_NAME)
public Filter springSecurityFilterChain() throws Exception {
boolean hasConfigurers = webSecurityConfigurers != null
&& !webSecurityConfigurers.isEmpty();
if (!hasConfigurers) {
WebSecurityConfigurerAdapter adapter = objectObjectPostProcessor
.postProcess(new WebSecurityConfigurerAdapter() {
});
webSecurity.apply(adapter);
}
return webSecurity.build();
}
Expected Behavior
I think the method should look like this:
/**
* Creates the Spring Security Filter Chain
* @return the {@link Filter} that represents the security filter chain
* @throws Exception
*/
@Bean(name = AbstractSecurityWebApplicationInitializer.DEFAULT_FILTER_NAME)
public Filter springSecurityFilterChain() throws Exception {
boolean hasConfigurers = webSecurityConfigurers != null
&& !webSecurityConfigurers.isEmpty();
if (!hasConfigurers && objectObjectPostProcessor != null ) {
WebSecurityConfigurerAdapter adapter = objectObjectPostProcessor
.postProcess(new WebSecurityConfigurerAdapter() {
});
webSecurity.apply(adapter);
}
return webSecurity.build();
}
Configuration
I am not currently sure why this ObjectPostProcessor is null by me. I will add details here, as soon as I figure it out. Still the NPE is something wrong, if the objectPostProcessor is not required.
Version
5.1.5-RELEASE. The code is still wrong in master, as far as I see
Sample
I think no sample is required, since the code is simple to understand.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at WebSecurityConfiguration.springSecurityFilterChain(), especially the objectObjectPostProcessor use described in the issue. Reproduce the case with webSecurityConfigurers present and no ObjectPostProcessor, then verify the filter chain builds without a NullPointerException when the issue's expected condition is met. Add or update regression coverage if the surrounding project tests identify an appropriate location.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100