spring-projects / spring-projects/spring-security
Generic Resolver Interface
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
We have quite a few places where we are resolving APIs. OAuth2AuthorizationRequestResolver, SAML is adding a resolver, JWT is adding one.
We should consider create a generic resolver that takes input of HttpServletRequest and a separate one for ServerWebExchange and outputs <T>.
There are also places where we use Function.
There are other places we use Converter.
We need to find consistency throughout the code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing OAuth2AuthorizationRequestResolver with the SAML and JWT resolvers mentioned in the issue, then review the existing uses of Function and Converter. Determine a consistent generic resolver shape for HttpServletRequest and ServerWebExchange that produces T; done means the relevant resolver patterns use that consistent approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design, security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100