spring-projects / spring-projects/spring-security

Make vertical bar | configurable in StrictHttpFirewall

Open
#5,506 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Summary

The implementation of StrictHttpFirewall should be extended with support for allowing the vertical bar |.

Actual Behavior

Currently the vertical bar cannot be whitelisted, and the firewall rejects the uri.

org.springframework.security.web.firewall.RequestRejectedException: The request was rejected because the URL contained a potentially malicious String "%7C"

Expected Behavior

Fine-grained configuration of the StrictHttpFirewall, adding the possibility to allow the vertical bar.

Alternatively the StrictHttpFirewall can be made more extendable by making urlBlacklistsAddAll and urlBlacklistsRemoveAll accessable.

Configuration
    @Bean
    public HttpFirewall allowUrlEncodedVerticalBarHttpFirewall() {
        StrictHttpFirewall firewall = new StrictHttpFirewall();
        firewall.setAllowVerticalBar(true);
        return firewall;
    }
Version

since 5.0.1

Sample
    private static final List<String> FORBIDDEN_VERTICALBAR = Collections.unmodifiableList(Arrays.asList("|", "%7c", "%7C"));

    /**
     * <p>
     * Determines if a vertical bar "|" or a URL vertical bar "%7C" should be allowed in
     * the path or not. The default is not to allow this behavior because it is a frequent
     * source of security exploits.
     * </p>
     * <p>
     * For example, due to ambiguities in the servlet specification a URL encoded period
     * might lead to bypassing security constraints through a directory traversal attack.
     * This is because the path is not parsed consistently which results  in different
     * values in {@code HttpServletRequest} path related values which allow bypassing
     * certain security constraints.
     * </p>
     *
     * @param allowVerticalBar a backslash "|" or a URL encoded backslash "%7C" be allowed
     *                         in the path or not. Default is false
     */
    public void setAllowVerticalBar(boolean allowVerticalBar) {
        if (allowVerticalBar) {
            urlBlacklistsRemoveAll(FORBIDDEN_VERTICALBAR);
        } else {
            urlBlacklistsAddAll(FORBIDDEN_VERTICALBAR);
        }
    }


Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the StrictHttpFirewall entry point and inspect how its URL blacklists are maintained and checked. Compare the existing configuration methods with the requested setAllowVerticalBar behavior, then verify that vertical bars remain rejected by default and can be allowed when configured. The issue does not name a test file, so locate the firewall tests covering URL rejection and configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.