spring-projects / spring-projects/spring-security
Remove Unnecessary Mock in OAuth Tests
Open
Nobody has claimed this yet.
in: oauth2
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
Domain objects are simple and should not need to be mocked. It adds unnecessary additional complexity and dependencies. This is especially true when mocking final classes that rely on powermock
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the OAuth tests that mock final domain classes and review how powermock is used there. Done means the unnecessary mocks and related complexity are removed while the OAuth tests continue to pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, authorization, testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100